Skip to content

Update file generation logic and file upload functionality for dev-execution. #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2025
Merged

Update file generation logic and file upload functionality for dev-execution. #5295

merged 5 commits into from
Jan 24, 2025

Conversation

@karanA-aws
Copy link
Contributor

@karanA-aws karanA-aws commented Jan 23, 2025 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Parameter Update for Testing:

Enhanced Development Prompt:

  • Modified GENERATE_DEV_FILE_PROMPT to support running install, build, and test commands independently.

Improved Build and Code File Upload Logic:

  • Updated the logic to enable uploading build files alongside code files.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karanA-aws karanA-aws requested review from a team as code owners January 23, 2025 19:55
@osdemah
Copy link
Member

osdemah commented Jan 23, 2025

/retryBuilds

osdemah
osdemah reviewed Jan 23, 2025
View reviewed changes
...t/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevSessionContextTest.kt Outdated
val txtFile = mock<VirtualFile>()
whenever(txtFile.extension).thenReturn("txt")
whenever(txtFile.path).thenReturn("file.txt")
whenever(txtFile.extension).thenReturn("mp4")
Copy link
Member

@osdemah osdemah Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably fix the name?

Copy link
Contributor Author

@karanA-aws karanA-aws Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name changed to mediaFile.
Also, .gitignore removed from upload exclusion set and tests updated accordingly.

@karanA-aws karanA-aws force-pushed the feature/dev-execution branch from 722d36a to 1d8e95d Compare January 23, 2025 22:39
@rli rli merged commit 232a273 into aws:feature/dev-execution Jan 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

+2 more reviewers

@osdemah osdemah osdemah approved these changes

@neilk-aws neilk-aws neilk-aws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karanA-aws @osdemah @rli @neilk-aws